diff --git a/.github/workflows/compile-test.yml b/.github/workflows/compile-test.yml index f953a536..652ac84c 100644 --- a/.github/workflows/compile-test.yml +++ b/.github/workflows/compile-test.yml @@ -27,8 +27,8 @@ jobs: ./gradlew generateMetadataFileForMavenPublication ./gradlew generatePomFileForMavenPublication ./gradlew publishToMavenLocal - cd ~/.m2/repository/io/papermc/paper/paper-server/1.20.2-R0.1-SNAPSHOT - mvn install:install-file -DgroupId=io.papermc.paper -DartifactId=paper-server -Dversion=1.20.2-R0.1-SNAPSHOT -Dpackaging=jar -Dfile=paper-server-1.20.2-R0.1-SNAPSHOT-mojang-mapped.jar + cd ~/.m2/repository/io/papermc/paper/paper-server/1.20.4-R0.1-SNAPSHOT + mvn install:install-file -DgroupId=io.papermc.paper -DartifactId=paper-server -Dversion=1.20.4-R0.1-SNAPSHOT -Dpackaging=jar -Dfile=paper-server-1.20.4-R0.1-SNAPSHOT-mojang-mapped.jar cd ~ - name: Compile ScalaLoader run: mvn --batch-mode --update-snapshots verify -DfinalName=ScalaLoader diff --git a/ScalaLoader-Common/src/main/java/xyz/janboerman/scalaloader/compat/Migration.java b/ScalaLoader-Common/src/main/java/xyz/janboerman/scalaloader/compat/Migration.java index f641f415..fd8f3da9 100644 --- a/ScalaLoader-Common/src/main/java/xyz/janboerman/scalaloader/compat/Migration.java +++ b/ScalaLoader-Common/src/main/java/xyz/janboerman/scalaloader/compat/Migration.java @@ -178,7 +178,7 @@ class PluginEventReplacer extends ClassVisitor { @Override public MethodVisitor visitMethod(int access, String name, String descriptor, String signature, String[] exceptions) { //if a plugin calls ScalaPluginEnableEvent#getPlugin() -> ScalaPlugin, replace the call by calling to ScalaPluginEnableEvent#getPlugin() -> IScalaPlugin instead. - //to keep compatibility, cast to ScalaPlugin again. This is a best-effort approach, it will fail if the plugin in a paper.ScalaPlugin. + //to keep compatibility, cast to ScalaPlugin again. This is a best-effort approach, it will fail if the plugin is a paper.ScalaPlugin. return new MethodVisitor(AsmConstants.ASM_API, super.visitMethod(access, name, descriptor, signature, exceptions)) { @Override