From e1da7173c5f54ae889fc30c2e282053166a167fc Mon Sep 17 00:00:00 2001 From: Jan Boerman Date: Tue, 13 Feb 2024 00:38:25 +0100 Subject: [PATCH] Add some commentary to ScalaPluginBootstrapContext and link to some documentation. --- .../paper/plugin/ScalaPluginBootstrapContext.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/ScalaPluginBootstrapContext.java b/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/ScalaPluginBootstrapContext.java index 5b0024a0..d24c44ad 100644 --- a/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/ScalaPluginBootstrapContext.java +++ b/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/ScalaPluginBootstrapContext.java @@ -12,6 +12,9 @@ public class ScalaPluginBootstrapContext extends ScalaPluginProviderContext implements BootstrapContext { + //TODO should perhaps use PaperLifecycleEventManager instead, since it contains some magic knowledge about the handlerConfiguration. + //TODO when should our booleanSupplier return false tho? I guess when all ScalaPlugins finished loading. + //TODO check https://gist.github.com/Machine-Maker/8e3fc6063c98e81cae7cee1ac230936f private final LifecycleEventManager lifecycleEventManager = new LifecycleEventManager() { @Override public void registerEventHandler( @@ -19,8 +22,7 @@ public void registerEventHandler( //TODO this is currently not called. when should this be called? should it be called at all? } }; - - + public ScalaPluginBootstrapContext(File pluginJarFile, ScalaPluginDescription description) { super(pluginJarFile, description); }