diff --git a/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/ScalaLoader.java b/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/ScalaLoader.java index b3fd6347..3c5b3e05 100644 --- a/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/ScalaLoader.java +++ b/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/ScalaLoader.java @@ -75,7 +75,6 @@ import java.util.Enumeration; import java.util.HashMap; import java.util.HashSet; -import java.util.Iterator; import java.util.LinkedHashSet; import java.util.List; import java.util.Map; diff --git a/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/ScalaPluginBootstrapContext.java b/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/ScalaPluginBootstrapContext.java index d24c44ad..38d9007f 100644 --- a/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/ScalaPluginBootstrapContext.java +++ b/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/ScalaPluginBootstrapContext.java @@ -22,7 +22,7 @@ public void registerEventHandler( //TODO this is currently not called. when should this be called? should it be called at all? } }; - + public ScalaPluginBootstrapContext(File pluginJarFile, ScalaPluginDescription description) { super(pluginJarFile, description); } diff --git a/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/description/DescriptionPlugin.java b/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/description/DescriptionPlugin.java index 3eb73001..4b31c91b 100644 --- a/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/description/DescriptionPlugin.java +++ b/ScalaLoader-Paper/src/main/java/xyz/janboerman/scalaloader/paper/plugin/description/DescriptionPlugin.java @@ -1,6 +1,5 @@ package xyz.janboerman.scalaloader.paper.plugin.description; -import org.bukkit.Bukkit; import org.bukkit.plugin.java.JavaPlugin; import xyz.janboerman.scalaloader.ScalaRelease; import xyz.janboerman.scalaloader.compat.IScalaPlugin; @@ -18,6 +17,8 @@ public class DescriptionPlugin extends JavaPlugin implements IScalaPlugin { private final ScalaPluginDescription description; private final Logger logger; + // TODO note: it should still be safe to register to plugin lifecycle events in a ScalaPlugin's constructor body. + protected DescriptionPlugin(ScalaPluginDescription description) { this.description = description; this.logger = new ScalaPluginLogger(this);