Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workbooks with chart extension #443

Open
JanMarvin opened this issue Nov 27, 2022 · 0 comments
Open

Support workbooks with chart extension #443

JanMarvin opened this issue Nov 27, 2022 · 0 comments
Milestone

Comments

@JanMarvin
Copy link
Owner

In 2014 someone decided, that having charts[0-9].xml was not enough and introduced chartEx[0-9].xml. These are used with newer chart options in Excel like histograms and box whisker plots.

Unfortunately this breaks the current logic of how we handle charts. Previously we had a nice little data frame in wb$charts where every chart could have a style and a color xml file. When loading we read the chart, color and style into the data frame. This needed a fix, because we can have chart1.xml and chartEx1.xml, but they use color1.xml, color2.xml, and style1.xml and style2.xml. (Oh and ofc they have chartEx1.xml.rels but I assume you already guessed this).

In a PR I'm a about to push in a moment, I have circumvented this by adding new columns to our data frame (chartEx and relsEx). This allows reading and writing the example input.

What needs to be added though is cloning.

@JanMarvin JanMarvin added this to the future milestone Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant