Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Forking and installing from fork doesn't work as expected #9

Open
sambriels opened this issue Feb 12, 2021 · 2 comments
Open

Forking and installing from fork doesn't work as expected #9

sambriels opened this issue Feb 12, 2021 · 2 comments
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@sambriels
Copy link

Hi,

Thanks for making this repo! Since some of the dependencies are out of date (10.4.4) I wanted to make a PR to apply some of the fixes to make sure we can use the latest versions (11.2.3 at the time of writing). I am probably missing something obvious, but whenever I install the forked repo, it shows up as

"nrwl": "github:sambriels/nx-react-native-expo",

In my package.json. This makes sense since the main package.json in this repo is referencing it like that. However, if I install your version it seems to take the (correct) package.json from the packages directory into account. I am not super familiar with publishing packages so I am probably missing something obvious here...

Could you maybe point me to how this repo should be forked? Maybe I can help out keep it up to date every now and again.

Thanks again for the repo!

@JacopoPatroclo
Copy link
Owner

Hi @sambriels. First of all thanks :)
So the main issue is what this repo is. Basically I'm using the same approach to the nrwl team to develop this package. You can find some reference here and here. The short answer is that what you are importing is not the package react-native-expo but the monorepo itself. The package is inside packages/react-native-expo. Moreover due to the fact that this plugin is written in typescript and nodejs as today does not support typescript out of the box, so there is a transpiling process needed. To build the library you must use the nx cli. In this case the command is yarn nx build react-native-expo or yarn build. After that you should have a dist/packages/react-native-expo directory. You shoul install that as a package using your local filesystem.

Hope my explanation is clear. I'm here if u need more support.

@JacopoPatroclo JacopoPatroclo added documentation Improvements or additions to documentation question Further information is requested labels Feb 12, 2021
@sambriels
Copy link
Author

Hi @JacopoPatroclo , aha! I see what you mean, thanks! I will have a look and see how for I get :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants