From 7fe5c7a93387874908b2886a0f6be09ca23cb56f Mon Sep 17 00:00:00 2001 From: Jackson Burns <33505528+JacksonBurns@users.noreply.github.com> Date: Wed, 25 Sep 2024 09:26:59 -0400 Subject: [PATCH 1/2] fix failing paper reproduction ci Paper was run pre-numpy 2 - need to keep that restriction here --- .github/workflows/reproduce_paper.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/reproduce_paper.yml b/.github/workflows/reproduce_paper.yml index 8fa97ff..1d089f7 100644 --- a/.github/workflows/reproduce_paper.yml +++ b/.github/workflows/reproduce_paper.yml @@ -36,6 +36,7 @@ jobs: python -m pip install -e .[molecules] python -m pip install scikit-learn==1.2.2 python -m pip install notebook + python -m pip install numpy<2 - name: Backup Reference Splits run: | cd examples/reproduce_paper_splits From d16ee2204b9cece4ed3176feefcd9e79601feecb Mon Sep 17 00:00:00 2001 From: Jackson Burns <33505528+JacksonBurns@users.noreply.github.com> Date: Wed, 25 Sep 2024 09:29:58 -0400 Subject: [PATCH 2/2] quote the numpy version so it doesn't get interpreted as a redirect --- .github/workflows/reproduce_paper.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reproduce_paper.yml b/.github/workflows/reproduce_paper.yml index 1d089f7..8098c61 100644 --- a/.github/workflows/reproduce_paper.yml +++ b/.github/workflows/reproduce_paper.yml @@ -36,7 +36,7 @@ jobs: python -m pip install -e .[molecules] python -m pip install scikit-learn==1.2.2 python -m pip install notebook - python -m pip install numpy<2 + python -m pip install "numpy<2" - name: Backup Reference Splits run: | cd examples/reproduce_paper_splits