Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Fix, Implement InlP Figure #88

Open
falquaddoomi opened this issue Oct 9, 2024 · 13 comments · May be fixed by #91
Open

[FEAT] Fix, Implement InlP Figure #88

falquaddoomi opened this issue Oct 9, 2024 · 13 comments · May be fixed by #91
Assignees
Labels
coding Coding experience (of any sort) would be helpful dataviz Data visualization enhancement New feature or request outreachy for outreachy interns package R package dev

Comments

@falquaddoomi
Copy link
Contributor

falquaddoomi commented Oct 9, 2024

We need to add figures 2 and 3 from the InlP paper, https://www.microbiologyresearch.org/docserver/fulltext/mgen/8/7/mgen000828.pdf. We have some code, written when the paper was published, that was used to generate those figures, but it's likely out of date and wasn't written to use MolEvolvR's job outputs. The figure will need to be integrated into the MolEvolvR web app, both for displaying on the site and including in the downloadable report.

Any progress on the following tasks would be appreciated:

  • getting the figure to render with its original inputs
  • adapting the code to use MolEvolvR's job output

I've included a sample MolEvolvR job output, 5uNQ9l, to demonstrate what files are typically included in a MolEvolvR job.

5uNQ9l_full.tar.gz

See PR #91 for the current code. If you self-assign this issue also assign yourself to that PR. Once your PR is ready, you can convert it from a draft to a regular PR and request review. If you prefer to not use that PR as a starting point, you're also free to create your own.

@falquaddoomi falquaddoomi added enhancement New feature or request outreachy for outreachy interns labels Oct 9, 2024
@falquaddoomi falquaddoomi added package R package dev coding Coding experience (of any sort) would be helpful labels Oct 9, 2024
@falquaddoomi falquaddoomi linked a pull request Oct 9, 2024 that will close this issue
11 tasks
@falquaddoomi falquaddoomi added the dataviz Data visualization label Oct 9, 2024
@valentina-buoro
Copy link
Collaborator

Hi @falquaddoomi I'd like to work on this

@valentina-buoro valentina-buoro self-assigned this Oct 13, 2024
@jananiravi
Copy link
Member

Let us know if anything is unclear, @valentina-buoro.

@valentina-buoro
Copy link
Collaborator

Hi @falquaddoomi , can I use data from this inlp repo https://github.com/JRaviLab/inlp_listeria to test the visualization for this task?

@falquaddoomi
Copy link
Contributor Author

Hi @valentina-buoro, I believe so, but @jananiravi would be able to give you a more sure answer.

@valentina-buoro
Copy link
Collaborator

Okay. The reason why I asked is because I don't seem to have access to the source code for the figurehttps://github.com/JRaviLab/molevol_data/blob/main/scripts/inlp/inlp_dual_plot.R and the table https://github.com/JRaviLab/molevol_data/blob/main/scripts/inlp/inlp_make_table.R @falquaddoomi @jananiravi

@falquaddoomi
Copy link
Contributor Author

@valentina-buoro I've just invited you to have read access to molevol_data, FYI, just in case you need it.

@valentina-buoro
Copy link
Collaborator

Thank you @falquaddoomi

@valentina-buoro
Copy link
Collaborator

@falquaddoomi , I'm trying to run the current code in #91 so I can see how it currently outputs the figure and table, but the input files used are not included in the sample MolEvolvR job output, 5uNQ9l attached to this issue. How can I resolve this please?

@falquaddoomi
Copy link
Contributor Author

Hey @valentina-buoro, that's kind of the meat of the issue: figuring out which, if any, of the files in the job results folder is similar to what the figure-generating code requires, and if not where to find the files it needs.

Just for some background, the figure-generating code from #91 has never actually been used in MolEvolvR; it was lifted from the original repo for the paper with the intent of integrating it into MolEvolvR, but it hadn't been integrated yet. You might consider touching base with @jananiravi or @epbrenner who likely have more insight into that code; I'm not familiar with it myself.

@valentina-buoro
Copy link
Collaborator

Thanks for the clarification @falquaddoomi

@valentina-buoro
Copy link
Collaborator

Hi @epbrenner @jananiravi .

I tried running some files in the job results folder with the figure-generating code, and I'm getting an error Error in plan(strategy = plan, .skip = T) : could not find function "plan" . Searching the code for the plan function gave no results. Pls could you give me a pointer to what may be going on.
The function I ran was inlp_fig2 .

@jananiravi
Copy link
Member

plan might be from the futures package. Also, I second Faisal's point. There are two primary file formats -- the tsv from the homolog tab and the iprscan file used by ipr2viz in the domain architecture tab. @epbrenner is this latter file now downloadable from molevolvr along with the new report generator by @the-mayer

@valentina-buoro
Copy link
Collaborator

Okay. Thank you @jananiravi .

@jananiravi jananiravi changed the title Fix, Implement InlP Figure 🆕 [FEAT] Fix, Implement InlP Figure Oct 26, 2024
@jananiravi jananiravi changed the title 🆕 [FEAT] Fix, Implement InlP Figure [FEAT] Fix, Implement InlP Figure Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding Coding experience (of any sort) would be helpful dataviz Data visualization enhancement New feature or request outreachy for outreachy interns package R package dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants