-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 메인페이지 UI 변경(알림 ui 변경) #133
base: develop
Are you sure you want to change the base?
The head ref may contain hidden characters: "refactor/#119_\uBA54\uC778\uD398\uC774\uC9C0_ui_\uBCC0\uACBD"
Conversation
@@ -71,8 +71,8 @@ | |||
@include font(2rem, 500, normal); | |||
@include line-clamp(2); | |||
border-bottom: 0.1rem solid #ccc; | |||
height: 6.36rem; | |||
|
|||
//height: 6.36rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주석 제거해주세요
@@ -19,7 +19,7 @@ export default function RootLayout({ children, isMainPage }: RootLayoutProps) { | |||
<div className={cn("container")}> | |||
<Header /> | |||
<main className={cn("children")}>{children}</main> | |||
<Footer isMainPage={isMainPage} /> | |||
{/* <Footer isMainPage={isMainPage} /> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주석 제거해주세요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Login.tsx의 error의 상태값은 사용하지 않고 있어서 삭제하는게 좋아보여요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금 sse가 연결이 계속 끊기네요. 머지하지 말고 시험 끝나면 백엔드와 테스트 해봐야 할 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sse의 연결 여부는 토큰의 유무로만 판단하면 될 것 같아서 isConnected에 해당하는 코드는 지워도 될 것 같아요.
PR 유형
변경 사항 요약
관련 이슈
close #119
체크리스트