Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converter for ground based tec from tenet network #1576

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

BenjaminRuston
Copy link
Collaborator

@BenjaminRuston BenjaminRuston commented Nov 8, 2024

Description

This adds a decoder for observations in TENET format which are ground based total electron content

Issue(s) addressed

Resolves #1583

Impact

Adds a ground based TEC decoder

Checklist

  • I have performed a self-review of my own code
  • I have run the unit tests before creating the PR

@BenjaminRuston BenjaminRuston added OBS OBS processing, UFO NAVY United States Naval Research Lab labels Nov 8, 2024
@BenjaminRuston
Copy link
Collaborator Author

@haydenlj this adds a couple new IODA definitions... one key one is that for IPP and forgot to ask @davidkuhl

it's maybe Ionospheric Pierce Point ?

@BenjaminRuston BenjaminRuston marked this pull request as ready for review November 19, 2024 18:41
@BenjaminRuston BenjaminRuston added the needs review Asking others to review - often used for pull requests label Nov 22, 2024
Copy link
Contributor

@haydenlj haydenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminRuston I was able to run

@haydenlj
Copy link
Contributor

haydenlj commented Dec 2, 2024

@haydenlj this adds a couple new IODA definitions... one key one is that for IPP and forgot to ask @davidkuhl

it's maybe Ionospheric Pierce Point ?

Ok I'll add these to the IODA definitions PR. Thanks!

@BenjaminRuston BenjaminRuston requested a review from fcvdb December 3, 2024 18:04
@BenjaminRuston BenjaminRuston added ready for merge PR is reviewed and is ready for merge and removed needs review Asking others to review - often used for pull requests labels Dec 7, 2024
Copy link
Collaborator

@huishao-r huishao-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenjaminRuston I checked the testoutput/obs.20201001T000000Z_PT1M_tec_groundbased.nc4, which only has one group, MetaData. There is no ObsValue group. Is it correct?

@BenjaminRuston BenjaminRuston removed the ready for merge PR is reviewed and is ready for merge label Dec 10, 2024
@BenjaminRuston
Copy link
Collaborator Author

@huishao-r this is fixed and can now make a plot of the data... notice the units for this TEC for the groundbased is in different units then the TEC from the space-based GNSS receivers.... they use something called TECU not sure what units these groundbased TEC are in

@fcvdb
Copy link
Contributor

fcvdb commented Dec 11, 2024

The test_iodaconv_tec_groundbased test passed, but the IODA validator prints some errors in the IODA conventions:

/work2/noaa/jcsda/fvandenb/skylab/jedi_2024121023_tec_ground_based_tenet_gnu_hercules/build/bin/ioda-validate.x "
--ignore-warn" "--ignore-error" "/work2/noaa/jcsda/fvandenb/skylab/jedi_2024121023_tec_ground_based_tenet_gnu_hercules/build/ioda/share/test/testinput//validation/ObsSpace.yaml" "/work2/noaa/jcsda/fvandenb/skylab/jedi_2024121023_tec_ground_based_tenet_gnu_hercules/jedi-bundle/iodaconv/test/testoutput/obs.20201001T000000Z_PT1M_tec_groundbased.nc4"

285:   Variable MetaData/stationIdentifierWMO
285:    ERROR: Variable 'MetaData/stationIdentifierWMO' is not listed in the YAML conventions file.
285:   Variable MetaData/xECEFPosition
285:    ERROR: File variable 'MetaData/xECEFPosition' has units of 'receiving station Earth Centered Earth Fixed X-coordinate in meters', which are invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NAVY United States Naval Research Lab OBS OBS processing, UFO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create an initial ground-based total electron content decoder
5 participants