Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp depreciation warning (again) #202

Merged

Conversation

EdwardSafford-NOAA
Copy link
Contributor

Fix timestamp deprecation warning in csv_data.py. This was fixed once but the file change was apparently lost during the confusion with the CI test failures.

Close #201

Re-fix timestamp deprecation warning.
Fix pycode style warnings.
Try uping cartopy version to get around CI test failure.
@CoryMartin-NOAA
Copy link
Collaborator

The documentation build is failing. Not sure if it is related to this PR or something else... Looks like it is failing on something in here:https://github.com/JCSDA-internal/eva-docs/tree/develop/.github/workflows Always something to chase with these GitHub Actions...

@EdwardSafford-NOAA
Copy link
Contributor Author

The EVA documentation dry run failure report is:

Error while loading conda entry point: conda-libmamba-solver (libarchive.so.19: cannot open shared object file: No such file or directory)

CondaValueError: You have chosen a non-default solver backend (libmamba) but it was not recognized. Choose one of: classic

From what I read on stackoverflow this can be fixed by modifying the conda install in eva-docs/.github/workflows/docs_dry_run.yaml to make the install line something along the lines of conda install --solver=classic conda-forge::conda-libmamba-solver conda-forge::libmamba conda-forge::libmambapy conda-forge::libarchive.

I'm not sure how to make that change to eva-docs and then test it in eva without first merging it into eva-docs/develop. Need some help there.

@CoryMartin-NOAA
Copy link
Collaborator

I'm not sure how to make that change to eva-docs and then test it in eva without first merging it into eva-docs/develop. Need some help there.
I think that's basically what we have to do @EdwardSafford-NOAA , and revert if we broke something.

@EdwardSafford-NOAA
Copy link
Contributor Author

Ok, I'll create a PR in eva-docs to do this and we'll start a bit of trial and error.

@EdwardSafford-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA the documentation test is passing today. I'm not going to ask any questions; I suggest we declare victory and move swiftly on.

Copy link
Collaborator

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@CoryMartin-NOAA CoryMartin-NOAA merged commit 2dc91b0 into JCSDA-internal:develop Aug 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Re-fix the time precision warning in csv_space.py, fix new(?) problem with ps plots
2 participants