-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timestamp depreciation warning (again) #202
Fix timestamp depreciation warning (again) #202
Conversation
Re-fix timestamp deprecation warning.
Fix pycode style warnings.
Try uping cartopy version to get around CI test failure.
The documentation build is failing. Not sure if it is related to this PR or something else... Looks like it is failing on something in here:https://github.com/JCSDA-internal/eva-docs/tree/develop/.github/workflows Always something to chase with these GitHub Actions... |
The EVA documentation dry run failure report is:
From what I read on stackoverflow this can be fixed by modifying the conda install in I'm not sure how to make that change to eva-docs and then test it in eva without first merging it into eva-docs/develop. Need some help there. |
|
Ok, I'll create a PR in eva-docs to do this and we'll start a bit of trial and error. |
@CoryMartin-NOAA the documentation test is passing today. I'm not going to ask any questions; I suggest we declare victory and move swiftly on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Fix timestamp deprecation warning in
csv_data.py
. This was fixed once but the file change was apparently lost during the confusion with the CI test failures.Close #201