Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time Series Capability #187

Merged
merged 10 commits into from
Jun 5, 2024
Merged

Add Time Series Capability #187

merged 10 commits into from
Jun 5, 2024

Conversation

danholdaway
Copy link
Collaborator

@danholdaway danholdaway commented May 14, 2024

Description

Add capability to read and transform on the fly and assemble dataset that has a time series dimension.

  • Add test for compiuting mean of omb and making time series.
  • Add test for plotting bias correction coefficients time series.
  • Add var bc data.
  • Add reader for JEDI bias and tlapse files.
  • Removed prints of datasets from read and transform classes and added to driver level.

Plots the new tests create shown below. Note that the tests are somewhat contrived since the data is the same at both time steps. We can try to improve on that in the future.

time_series_omb

varbc_time_series

Dependencies

NONE

Impact

NONE

@CoryMartin-NOAA
Copy link
Collaborator

@danholdaway did the CI test fail because of yet another python version/dependency issue in the container?

src/eva/data/jedi_variational_bias_correction.py Outdated Show resolved Hide resolved
src/eva/data/jedi_variational_bias_correction.py Outdated Show resolved Hide resolved
src/eva/data/jedi_variational_bias_correction.py Outdated Show resolved Hide resolved
src/eva/data/jedi_variational_bias_correction.py Outdated Show resolved Hide resolved
src/eva/eva_driver.py Show resolved Hide resolved
src/eva/eva_driver.py Outdated Show resolved Hide resolved
src/eva/time_series/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danholdaway for adding this feature. I'm looking forward to test this in the workflow level.

src/eva/utilities/duration.py Show resolved Hide resolved
src/eva/time_series/time_series.py Show resolved Hide resolved
@Dooruk Dooruk linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link
Collaborator

@asewnath asewnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to create a test plot for our 3dvar_atmos run, thanks for adding this feature into eva!

@danholdaway danholdaway merged commit d60260f into develop Jun 5, 2024
5 checks passed
@danholdaway danholdaway deleted the feature/time_series branch June 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time series in EVA?
4 participants