Modify mon_data_space.py to differenciate between data file types #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify 1-d read to handle both fortran and perl binary files.
EdwardSafford-NOAA
requested review from
CoryMartin-NOAA,
ADCollard and
kevindougherty-noaa
ADCollard
approved these changes
Jan 12, 2024
CoryMartin-NOAA
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
mon_data_space.pyto correctly handle single dimension data files in both fortran and perl binary formats.Not all binary files are created equal. All of the legacy DA monitor data is created by Fortran executables except for MinMon, which are created by perl scripts using
binary packformat. The two file types cannot both be read correctly byf.read_reals(). This fix adds an attribute to distinguish between data extracted from gsistat files (MinMon) and all others.This fix has been tested with RadMon data, both global and regional, and MinMon data. All tests pass.
Completes #173