Separate Instance and Minecraft Directory Selection #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force-pushed to address a revert of the "Iris Only" and "Iris + Fabric" labels, since they were updated in-code but not in the underlying .form file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the selection of separate instance and Minecraft directories. This was done to simultaneously address #40 without also causing issues for players who make separate folders for different instances.
Since Iris' installer is very beginner-friendly, I'm interested to hear if we should hide the "Minecraft directory" selection behind an "advanced" checkbox or not. On one hand, it may cause extra confusion, though on the other hand, the defaults are good as-is for people who would be confused in that situation.
This can be tested by launching the Minecraft Launcher with
--workDir SOME_PATH, then pointing the Minecraft directory to that same path. The instance directory can be pointed anywhere, including that same path. I've tested this using two different paths, neither of which were the usual.minecraftand both being pointed to.minecraft. I haven't tested this on macOS or Linux, though I don't foresee any issues cropping up there (famous last words).Please let me know if you want me to make any changes, address any issues, and/or do any code cleanup. I tried to follow what the codebase was already doing, but I'm also happy to clean things up instead while I'm here.
Closes #40.