Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research city state gem upgrade for use in setting location based on buckets #4563

Closed
dboyer opened this issue Mar 6, 2024 · 4 comments
Closed
Assignees

Comments

@dboyer
Copy link

dboyer commented Mar 6, 2024

Goals:

  1. Determine if we want to use the city-state gem
  2. Determine how to get rid of our forked version and instead use the version through the gem source
@viviancan
Copy link
Contributor

btw here is the our fork of the gem

@viviancan viviancan self-assigned this Mar 11, 2024
@viviancan
Copy link
Contributor

I think the city state gem will work. As a proof of concept, I removed the forked version and added the original city-state gem. I created an maxmind account using the engineering email. Credentials & license key in password manager.

Following this blog post I created a basic rails form in place of the original location vue form to test out the idea. I think this path forward will work as expected. I did not try to "update" the city-state data yet, but the docs state the data can be updated using the following

CS.set_license_key('MY_KEY')

CS.update

Based on this information, I am moving this ticket into the review/QA and we can determine next steps!

Private Zenhub Video

@shaun-technovation
Copy link
Contributor

I started looking at the city-state gem too, looks like it's a good out-of-the-box option.

If we want to add additional location data (which the gem supports)... I was able to add an additional state, but I wasn't able to add an additional city, looks like other people are running into this issue to:

That's one downside I'm seeing is that the gem maintainer(s) aren't very active/responsive. But, perhaps this gem will work if we don't need any customizations. 🤔

@shaun-technovation
Copy link
Contributor

Also, re: customizing, looks like we can provide our own data source too (perhaps getting the Maxmind data and appending to it), if we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants