Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

I'm Landmaster, and I'm volunteering to tackle the ≥1.14.4 update. #612

Open
Landmaster opened this issue Dec 29, 2019 · 13 comments
Open

Comments

@Landmaster
Copy link

Landmaster commented Dec 29, 2019

Hello. I'm Landmaster, and you may know me as the creator of the Tinkers addon PlusTiC. I saw that you were looking for someone to bring this mod to 1.14.4 and later versions, and I'm here to ask if I can help create a rewrite of this mod in order to port it to said versions. So far, I've been able to get buttons and a basic (i.e. sorting by translation key) sorting implementation working, and I've created a repository containing my early work on the port that I started yesterday. If you guys have any questions/concerns, please feel free to reply to this issue.

BTW, thanks for the work that you've done for modded Minecraft over the years!

Kind regards,
Landmaster
Eminentia ex minimis

@MrLittle12
Copy link

A billion times yes!
Please.

@Kobata
Copy link
Collaborator

Kobata commented Dec 30, 2019

The biggest comment I'll add here is that Inventory Tweaks does a ton more than just a simple static sort -- the order depends on client configuration (the tree files), for the main inventory there's the whole second layer of being able to force specific items into specific slots, etc.

This means it's not really well-suited to being implemented entirely on the server, unlike, say cpw's simpler sorter, at least without spending a ton of effort to make sure everyone's configurations get synced to the server somehow.

(This goes kinda doubly if you end up implementing something like the API used to support the old AE2 mode where it essentially has to have an ordering function on the client inside AE2's list sorting)

@Landmaster
Copy link
Author

@Kobata Fair enough. The translation key sorting that I have so far is only temporary and I'll definitely replace it with a customizable config-based one once I get the basic functionality working.

@mkalam-alami
Copy link
Collaborator

mkalam-alami commented Jan 2, 2020

Synchronizing custom configs with the server seems possible, so maybe a server-based implementation can be a good approach. While very different, it would probably be more stable, performant and resistant to Minecraft API changes so I'm not against the idea.

I've never written a server mod but if I get this well, the main downside is just that the mod would only work for local games + servers where the mod is installed on both the client and server, instead of working everywhere by default. With also the concern of packet retrocompatibility between client & server I think.

Thanks for tackling this and best wishes for the rewrite 😄

(PS. When you get to custom configs, I hope using the same file names and format will be considered! Making IT Reborn a drop-in replacement without having players rewrite the config would be a killer feature)

@Landmaster
Copy link
Author

I've already pushed a few beta builds for the rewrite, though I'm waiting for CurseForge to approve the project.

@Landmaster
Copy link
Author

First builds are released at https://www.curseforge.com/minecraft/mc-mods/it-reborn!

@Sheepotastic
Copy link

Like the idea, don't like that its stuck with needing to be installed client side, makes it kinda useless for me, I don't play singleplayer or on servers where I can freely add mods to them

@Announcement
Copy link

Anything I can do to help? give me instructions api links for tasks that need to be written/converted, documentation or test suites to write and i got you :p I'm just not really up for handling and investigating on my own at this moment without some encouragement/motivation/interest

@TheBeardedQuack
Copy link

Hi Landmaster,
I would also like to volunteer some of my time to aid with rebuilding this mod. While I have barely any Java experience (I did a few tiny things with the old mod loader way back when) I have worked with C++ and C# professionally for the last 5 years. I can help test and track down bugs with the stack traces, even if I can't fix bugs I can help provide detailed steps to reproduce and find.

I was looking for small open source mod to get help contribute to in order to expand my expertise with Java and I loved using inventory tweaks, I'd like to help bring it up to date.

@Landmaster
Copy link
Author

@TheBeardedQuack Check out the project's GitHub at https://github.com/Landmaster/InvTweaksReborn

Also, Inventory Tweaks is now on 1.15.2!

@FinchHub
Copy link

FinchHub commented Mar 6, 2020

Ah, man. The entire charm of InvTweaks was that it could be used client-side; I was looking forward to the idea of being able to use this on a realm. That sucks.

At least it's being worked on again. Good effort.

@Landmaster
Copy link
Author

@Vulano The client-side functionality is on my to-do list (https://github.com/Landmaster/InvTweaksReborn/issues/8).

@Lyraedan
Copy link

Lyraedan commented Mar 20, 2020

I'd be more then happy to rewrite InventoryTweaks from the ground up for compatibility with Fabric.
It'll function exactly the same to the end user they wouldn't even notice a difference.
I'll do this for 1.15+

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants