Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix c_char type bug and add source dist #33

Conversation

mkhazin-r7
Copy link
Contributor

@mkhazin-r7 mkhazin-r7 commented Jul 24, 2024

There is a bug, where we call the function pyo3::ffi::PyUnicode_FromStringAndSize with the wrong parameter - i8 instead of c_char. This is probably because the documentation also wrongfully used i8. c_char can be i8 or u8, depending on the system, so that's the reason why it compiles on some systems and doesn't work on others.

I also added a source distribution, to allow installing with pip on systems where the precompiled release won't work, like the python3.11-alpine docker image.

@mkhazin-r7 mkhazin-r7 changed the title ix c char type bug and add source dist Fix: fix c_char type bug and add source dist Jul 24, 2024
@tyatziv-r7 tyatziv-r7 merged commit 9725011 into Intsights:master Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants