Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php8 compatibility #69

Open
gturri opened this issue Feb 1, 2022 · 2 comments
Open

php8 compatibility #69

gturri opened this issue Feb 1, 2022 · 2 comments

Comments

@gturri
Copy link
Contributor

gturri commented Feb 1, 2022

According to dc87f31 http-mock is compatible with PHP8. It would be really cool to release a package which updates this constraint in order to be able to use http-mock on a CI running on this version of PHP8.
Is it something you could consider doing?
@4d4ch4u32
Copy link

4d4ch4u32 commented Mar 3, 2022 •
edited
Loading

I would also like to use it, in a PHP 8 project.

@dudapiotr
Copy link

Any progress to merge it into master?

gturri added a commit to Zero-Waste-Paris/membership-scripts that referenced this issue Dec 28, 2022
@gturri
Disable usage of http-mock
ad444ff 
that package is not compatible with PHP8. We opened an issue
related to that almost a year ago (see
InterNations/http-mock#69 ), and we tried
updating it ourselves, but it appears to be non trivial.

Since I'm now not able to run those tests on my laptop (since I
upgraded to ubuntu 22.04) I'm deactivating the associated tests
(not completely deleting them for now as I still hope it will
be possible to reactivate them soon and since I'm afraid deleting
them would just lead to completely forget them)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gturri @dudapiotr @4d4ch4u32