Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http-mock to work with Guzzle 6 #14

Open
lstrojny opened this issue Jan 27, 2015 · 8 comments
Open

Update http-mock to work with Guzzle 6 #14

lstrojny opened this issue Jan 27, 2015 · 8 comments

Comments

@lstrojny
Copy link
Contributor

No description provided.

@alexeyshockov
Copy link
Contributor

I can pick it on the next week.

@lstrojny
Copy link
Contributor Author

Cool, thank you!

@alexeyshockov
Copy link
Contributor

Is it about Guzzle 6 already? Now it makes sense to migrate directly to this version, I think. The issue was created long time ago, so I would like to be sure :)

@lstrojny lstrojny changed the title Update http-mock to work with Guzzle 5 Update http-mock to work with Guzzle 6 Apr 28, 2016
@lstrojny
Copy link
Contributor Author

Very true, let’s go to Guzzle 6.

@Ugoku
Copy link

Ugoku commented Jul 8, 2016

Any news on this?

I got the following warning when installing http-mock "Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead."
Then after installing, it doesn't seem to work, as there is no hard Guzzle version requirement and things (function calls etc) change around a lot depending on which Guzzle version is installed...

@b1rdex
Copy link

b1rdex commented Apr 27, 2017

OK guys, I think it's already time to face this issue and drop guzzle v3.
Can we discuss some roadmap/plan how these can be done?
We should split migration to new guzzle to simple and clear steps so it it would be easier to implement.

I would contribute if there will be clear vision of what and how needs to be done to migrate.

@lstrojny
Copy link
Contributor Author

Thanks for everybody’s interest in this. It’s basically these steps:

  • Update to a recent guzzle (replace guzzle/guzzle with guzzle/guzzlehttp)
  • Fix the namespaces and method names and run the tests and see what breaks
  • Fix stuff that breaks (most work will probably be in the UnifiedRequest class)

I myself have no time right now to work on this but I am happy to answer any questions in between if somebody else picks this up. While I don’t like the fact that we are depending on an abandoned library, http-mock is a testing only library and should never be used close to production anyway.

@b1rdex
Copy link

b1rdex commented May 29, 2017

For all interested — take a look at https://github.com/mcustiel/phiremock
It has same approach, but already on guzzle 6+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants