Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Handler Naming Conventions + Code Re-org #192

Open
ifadams opened this issue Jul 24, 2024 · 0 comments
Open

Query Handler Naming Conventions + Code Re-org #192

ifadams opened this issue Jul 24, 2024 · 0 comments
Labels
Enhancement New features or upgrades for functionality, performance, etc Priority: Backlog Tasks that are not pressing, but to be tracked and revisited Workflow Improvements specific to development workflow (i.e. CI changes, unit testing, etc.)

Comments

@ifadams
Copy link
Contributor

ifadams commented Jul 24, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Additional context****Is your feature request related to a problem? Please describe.

As we are adding new query handlers and deprecating "old" code, we're running into issues with confusing naming conventions an messy code organization, with a proliferation of things named "handler" with no distinction between backend handlers (e.g. PMGD interactions) and server side "front-end" handling (query parsing and working with backend to create, issue, and handle graph DB interactions).

Describe the solution you'd like

We need a few things

  1. A common naming convention to disambiguate query handling and interactions between the front end server side logic (parsing, creating, running operations, etc)
  2. Consider changing code organization to include one or more subdirectories specific to the above "front" and "back" end modules. This should both improve organization and readability, and improve clarity for code re-use.

Additional context
Discussion needed to reach agreement on naming and organizational scheme, as well as coordination to make sure we dont massively break ongoing development.

@ifadams ifadams added Enhancement New features or upgrades for functionality, performance, etc Workflow Improvements specific to development workflow (i.e. CI changes, unit testing, etc.) Priority: Backlog Tasks that are not pressing, but to be tracked and revisited labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or upgrades for functionality, performance, etc Priority: Backlog Tasks that are not pressing, but to be tracked and revisited Workflow Improvements specific to development workflow (i.e. CI changes, unit testing, etc.)
Projects
None yet
Development

No branches or pull requests

1 participant