Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus metrics #132

Open
fcomte opened this issue May 23, 2022 · 1 comment
Open

prometheus metrics #132

fcomte opened this issue May 23, 2022 · 1 comment

Comments

@fcomte
Copy link
Contributor

fcomte commented May 23, 2022

We should expose prometheus metrics :

  • counter for packages creation by package and user
  • counter for packages deletion by packages and user
  • running duration of the service when deleted
@alexisdondon
Copy link
Contributor

do you suggest metrics like this?
onyxia_service_creation_total{service="jupyter-python",user="user or group",} 3.0
onyxia_service_deletion_total{service="jupyter-python",user="user or group",} 3.0

https://prometheus.io/docs/practices/naming/

CAUTION: Remember that every unique combination of key-value label pairs represents a new time series, which can dramatically increase the amount of data stored. Do not use labels to store dimensions with high cardinality (many different label values), such as user IDs, email addresses, or other unbounded sets of values.

To do that you should look forward aggregations log system for high cardinality metrics -> ELK for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants