Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hero button #157

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Fix hero button #157

merged 4 commits into from
Nov 30, 2024

Conversation

pixup1
Copy link
Member

@pixup1 pixup1 commented Nov 26, 2024

Description

I did it

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

#114

@pixup1 pixup1 added the bug Something isn't working label Nov 26, 2024
@pixup1 pixup1 requested review from KwikKill and floflo0 November 26, 2024 08:40
@pixup1 pixup1 linked an issue Nov 26, 2024 that may be closed by this pull request
Home page arrow #114
Closed
4 tasks
KwikKill
KwikKill approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

floflo0
floflo0 reviewed Nov 27, 2024
View reviewed changes
src/components/Hero.vue Outdated Show resolved Hide resolved
@floflo0 floflo0 merged commit f931923 into dev Nov 30, 2024
3 checks passed
@floflo0 floflo0 deleted the hero-button branch December 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floflo0 floflo0 floflo0 approved these changes

@KwikKill KwikKill KwikKill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home page arrow
3 participants
@pixup1 @KwikKill @floflo0