Deref user tournaments #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KwikKill
force-pushed
the
deref_user_tournaments
branch
from
b0ec36d to
86a4377
Compare
Lugrim
requested changes
Nov 19, 2023
There was a problem hiding this comment.
It looks like it's working, however the code base (especially the variable names) should be reworked to keep it understandable.
Also, tests should be added, it may be done later though (please open an issue and mention it here to keep a trace of what's happening)
Lymkwi
reviewed
Nov 20, 2023
KwikKill
force-pushed
the
deref_user_tournaments
branch
from
86a4377 to
6985ce4
Compare
Lugrim
approved these changes
Nov 20, 2023
Lymkwi
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fields to populate user dashboard with less API requests