Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tournament and team missing fields #49

Closed
3 tasks done
ShiroUsagi-san opened this issue Sep 11, 2023 · 9 comments
Closed
3 tasks done

Tournament and team missing fields #49

ShiroUsagi-san opened this issue Sep 11, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request priority:high High Priority
Milestone

Comments

@ShiroUsagi-san
Copy link
Contributor

ShiroUsagi-san commented Sep 11, 2023

Somes fields and constrains are missing:

  • max players in a team
  • max teams in a tournament
  • cashprize of a tournament
@ShiroUsagi-san ShiroUsagi-san added the enhancement New feature or request label Sep 11, 2023
@ShiroUsagi-san
Copy link
Contributor Author

We also need to define how is handled the captain of a team. This special player can change their team mates, kick them for instance

@Lymkwi
Copy link
Collaborator

Lymkwi commented Sep 12, 2023

On it chief

@Lymkwi
Copy link
Collaborator

Lymkwi commented Sep 12, 2023

  • What would be a reasonable upper limit to the number of players in a team? (I'd say 48 just because that's the maximum amount of people we can fit on one of our switches)
  • Isn't the maximum number of teams dependent on the game? Would the upper limit be, for example, the number of players we get in singleplayer games like TM2020 (I don't remember how many there were last year, something like 64 people)
  • Cashprize field can go with Missing tournament features #31 . Can I just making an Int or should we also detail other cash prizes (1st wins this, second wins this, and so on)

@ShiroUsagi-san
Copy link
Contributor Author

  • the upper limite should be configurable by admins
  • You're right, the upper limit is determined by the game type
  • I think the cashprize repartion is better and the total can be computed with ease

@Lymkwi
Copy link
Collaborator

Lymkwi commented Sep 17, 2023

  • I'm not sure you can modify a SQL constraint through a form admins can fill in. The best I can do is try and force a registration to fail if there are too many, dynamically at save time, but that's gonna be dirty. A DB hard limit would be easier
  • Should I also set a fixed number of teams per tournament, or try and handle it at runtime? What happens
  • In both cases, what happens if we lower the limit below the current number of teams? Should I prevent that from being possible?
  • How should the cashprize be formatted? I can make it an ordered list of ints, I just do not know what representation makes the most sense

@ShiroUsagi-san
Copy link
Contributor Author

  • the admin have to set the max number of players and teams in a tournament
  • that's a good question, we need to refer to the tournament team(but seems an impossible case )
  • your idea sounds great to me

@Lugrim
Copy link
Contributor

Lugrim commented Sep 29, 2023

While working on previous DB migration, I stumbled on some possibly missing fields :

  • The participant type (team vs single player) (not needed)
  • Minimal number of players to consider a team as valid (computed at runtime)
  • Registration open & closing datetimes
  • Price related fields (Online price, onsite price)
  • Locked tournaments / events ?
  • Maximum manager count

@Lugrim Lugrim modified the milestone: Production Oct 7, 2023
@Lymkwi Lymkwi added the priority:high High Priority label Oct 12, 2023
@Lymkwi Lymkwi added this to the Production milestone Oct 12, 2023
@Lymkwi Lymkwi mentioned this issue Oct 20, 2023
3 tasks
Lymkwi added a commit that referenced this issue Oct 20, 2023
Use an ArrayField, which is Postgresql specific, to store a list of
Decimal fields that have a minimal value of 0.

Also adds tests, and is needed for #49.
Lymkwi added a commit that referenced this issue Oct 23, 2023
Use an ArrayField, which is Postgresql specific, to store a list of
Decimal fields that have a minimal value of 0.

Also adds tests, and is needed for #49.
Lymkwi added a commit that referenced this issue Oct 26, 2023
Use an ArrayField, which is Postgresql specific, to store a list of
Decimal fields that have a minimal value of 0.

Also adds tests, and is needed for #49.
@Lymkwi
Copy link
Collaborator

Lymkwi commented Nov 25, 2023

I think once #97 is good we can close this.

EDIT: almost, we would still be missing public/private tournaments, and manager counts

@KwikKill
Copy link
Member

KwikKill commented Aug 9, 2024

Closing this as this is quite old and only one thing's missing (#162 will take over)

@KwikKill KwikKill closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high High Priority
Projects
None yet
Development

No branches or pull requests

4 participants