From 972745e888bc2a114553450c72022c0fd0a781ce Mon Sep 17 00:00:00 2001 From: Kent Huang Date: Mon, 23 Oct 2023 21:27:59 -0500 Subject: [PATCH 1/2] [Chore] Update cli.py to add some comments Add some comments to explain the feature flag of `--enable-quick-look-share` implemented by #889 Signed-off-by: Kent Huang --- piperider_cli/cli.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/piperider_cli/cli.py b/piperider_cli/cli.py index 6f9f70300..52b057ca6 100644 --- a/piperider_cli/cli.py +++ b/piperider_cli/cli.py @@ -69,6 +69,10 @@ def dbt_select_option_builder(): ] feature_flags = [ + # Quick Look (https://cloud.piperider.io/quick-look) is a public-facing page on PipeRider Cloud. + # Every user can paste the GitHub repo or PR URL, and PipeRider Cloud will analyze that URL by the CLI on the air. + # The reports on the Quick Look are default shared public with a limited time. + # PipeRider Cloud uses this feature flag to upload those reports to the Quick Look storage. click.option('--enable-quick-look-share', envvar='PIPERIDER_ENABLE_QUICK_LOOK_SHARE', is_flag=True, default=False, hidden=True, help='Enable share to Quick Look.') ] From a1fd553a4473b36d1308ef95d088b9a4b5153138 Mon Sep 17 00:00:00 2001 From: Kent Huang Date: Tue, 24 Oct 2023 10:50:59 +0800 Subject: [PATCH 2/2] [Update] Move comment to other place Signed-off-by: Kent Huang --- piperider_cli/cli.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/piperider_cli/cli.py b/piperider_cli/cli.py index 52b057ca6..f9b02c2b2 100644 --- a/piperider_cli/cli.py +++ b/piperider_cli/cli.py @@ -68,11 +68,11 @@ def dbt_select_option_builder(): ] +# Quick Look (https://cloud.piperider.io/quick-look) is a public-facing page on PipeRider Cloud. +# Every user can paste the GitHub repo or PR URL, and PipeRider Cloud will analyze that URL by the CLI on the air. +# The reports on the Quick Look are default shared public with a limited time. +# PipeRider Cloud uses this feature flag to upload those reports to the Quick Look storage. feature_flags = [ - # Quick Look (https://cloud.piperider.io/quick-look) is a public-facing page on PipeRider Cloud. - # Every user can paste the GitHub repo or PR URL, and PipeRider Cloud will analyze that URL by the CLI on the air. - # The reports on the Quick Look are default shared public with a limited time. - # PipeRider Cloud uses this feature flag to upload those reports to the Quick Look storage. click.option('--enable-quick-look-share', envvar='PIPERIDER_ENABLE_QUICK_LOOK_SHARE', is_flag=True, default=False, hidden=True, help='Enable share to Quick Look.') ]