Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use database connection pool (DBCPConnectionPool) controller service in LDESClientProcessor #677

Open
SBylemans opened this issue Aug 21, 2024 · 1 comment
Assignees
Labels
needs triage Issue needs to be evaluated by team

Comments

@SBylemans
Copy link

SBylemans commented Aug 21, 2024

Is your feature request related to a problem? Please describe.
Currently the LDESClientProcessor defines it's own entityManagers and handles those connections to the DB, using StatePersistenceFactory. This introduces a whole heap of problems:

  1. Transactions not being closed properly Transaction is already active error #678
  2. Using all of the database connections
  3. Reusing a database connection of a processor with the same name, for which the connection parameters may not be the same. For Relation 'treenoderecordentity' does not exist #676, I created a processor with the same name as another LDESClientProcessor. Trying to start that processor resulted in the same error as in the ticket while having other connection details.
  4. ...

Describe the solution you'd like
The LDESClientProcessor should use the DBCPConnectionPool controller service of NiFi in order to obtain a database connection. Inspiration of use can be taken from the PutSQL processor of NiFi itself.

Additionally, to query and handle transactions and such, one could use additional libraries such as jOOQ which is more flexible than Hibernate.

@SBylemans SBylemans added the needs triage Issue needs to be evaluated by team label Aug 21, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in VSDS Backlog Aug 21, 2024
@jobulcke

This comment has been minimized.

@pj-cegeka pj-cegeka self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be evaluated by team
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants