Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group internal attributes in Canopy into cohort and community objects. #337

Closed
Tracked by #321
davidorme opened this issue Oct 19, 2024 · 0 comments · Fixed by #341
Closed
Tracked by #321

Group internal attributes in Canopy into cohort and community objects. #337

davidorme opened this issue Oct 19, 2024 · 0 comments · Fixed by #341

Comments

@davidorme
Copy link
Collaborator

davidorme commented Oct 19, 2024 •
edited
Loading

Not so sure about this one, but Canopy has some attributes that are per cohort (stem leaf area, etc.) and some that are for the whole canopy. So some attributes are always (n_heights, n_cohorts) and some are always (n_heights,) in shape. If we group those into specific dataclasses, then those can inherit the PandasExporter class and it's also a bit more structured.
@davidorme davidorme mentioned this issue Oct 19, 2024
Open
25 tasks
This was referenced Oct 21, 2024
Merged
Merged
Merged
@davidorme davidorme linked a pull request Oct 23, 2024 that will close this issue
Group internal attributes in canopy into data classes #341
Merged
7 tasks
@davidorme davidorme moved this from Todo to Review in ICCS development board Oct 23, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in ICCS development board Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
ICCS development board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Group internal attributes in canopy into data classes ImperialCollegeLondon/pyrealm
1 participant
@davidorme