Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore structures to synchronise trait details across the two PFT traits, Flora and Stem Traits. #301

Open
Tracked by #321
davidorme opened this issue Sep 28, 2024 · 0 comments

Comments

@davidorme
Copy link
Collaborator

@j-emberton commented on #300 that the definitions of Flora and StemTraits are repetitious

I did look at all sorts of things here - Protocols and ABC and inheritance, but these classes are basically intended to deal with two different constructor signatures, even if they share nearly all the attributes. That seems to make any kind of inheritance more finicky than just duplicating stuff.

I may have missed something - I'd love a way to share that set of attributes cleanly across the two PFT traits, Flora and Stem Traits. The #300 PR was merged to establish that common API on the attributes and get the next PR in to close out the functionality hanging in #296.

This issue is to remind us to circle back to look at how to improve the implementation later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant