Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: cache more docs #264

Merged

Conversation

YaelDillies
Copy link
Contributor

The current list is very outdated.

The current list is very outdated.
@kbuzzard
Copy link
Collaborator

kbuzzard commented Dec 2, 2024

@pitmonticone what do you think of this?

@pitmonticone
Copy link
Collaborator

pitmonticone commented Dec 2, 2024

Hi @YaelDillies, thank you very much! You're right, the list is definitely outdated.

What about saving to cache the whole .lake/build/doc without excluding any sub-contents?

I'm doing it in multiple projects (InfinityCosmos, Carleson, Equational) and it works perfectly fine without occupying too much memory.

@YaelDillies
Copy link
Contributor Author

Does it do the right thing with the project's own docs? If so, then yes that's definitely cleaner!

@pitmonticone
Copy link
Collaborator

Yes, it does. See here for example.

@pitmonticone
Copy link
Collaborator

pitmonticone commented Dec 2, 2024

Unfortunately, I'm from mobile now.

Feel free to push it directly so I can review and merge it.

Copy link
Collaborator

@pitmonticone pitmonticone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Yaël!

LGTM!

@kbuzzard
Copy link
Collaborator

kbuzzard commented Dec 2, 2024

Thanks a lot!

@kbuzzard kbuzzard merged commit 177921c into ImperialCollegeLondon:main Dec 2, 2024
2 checks passed
@YaelDillies YaelDillies deleted the cache_more_docs branch December 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants