-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations don't load/render when Slim viewer backed by DICOMWeb service of Google Cloud Healthcare API. Affects Pan-Cancer-Nuceli-Seg-DICOM collection in IDC Portal. #238
Comments
FYI @fedorov. Annotations with Google Healthcare API now working. Resolution: the simple "fix" is to use the preview version of the Google Healthcare API, i.e. use https://healthcare.googleapis.com/v1beta1/... in the config / servers.url. I kindly suggest you (1) add this to your documentation in a prominent place, and (2) evaluate to apply for the IDC Portal of NCI, as rendering of all bulk annotations is broken there. Note: Might be worth a try to check if that as well resolves #169 |
@helmut-hoffer-von-ankershoffen glad you figured it out! While we did release this dataset in IDC (sharp eyes!), we intentionally did not advertise it exactly because we have not completely sorted out the visualization issues in Slim. There is some groundwork in the IDC proxy that needs to be done first to properly handle bulk data requests (we are working on this), but also on the viewer side, we sometime run into memory issues with large annotation sizes. We are also planning to implement download in a separate thread so the UI is not locked. #169 is a separate issue, and it was not working due to missing support of BitsAllocated=1 as needed for DICOM SEG. That was implemented in production Google Healthcare API, and we confirmed that is resolved.
We will, once all the functionality we are working on is in place. But since you discovered this dataset, can you share any comments about using those bulk annotations with Slim, especially large ones? Do you have any comments or wishes? |
Hi @fedorov , thx for confirming.
|
We talk briefly about the proxy here: https://learn.canceridc.dev/portal/proxy-policy. The main reasons for the proxy:
Aside from taking care of the 2 points above, proxy is passing everything through, with the exception of bulk data requests, which is currently under development. Currently, proxy points to "v1", not "v1beta1" API.
Nice! I forgot we mentioned it there. That was an aspirational statement, as stated in the paper: "The DICOM Microscopy Bulk Simple Annotations and Segmentation objects are in the process of being included into the IDC and will soon become available via the IDC portal, too." "Soon" became reality just a few month ago (and binary segmentations are still not in!)! :-D Anyway, no need to hide that those annotations are in IDC - it's just that we are not highlighting its availability until users can visualize them in the viewer. |
TL;DR Loading/rendering of annotations broken when Slim viewer backed by DICOMWeb service of Google Cloud Healthcare API. This affects the IDC portal, in particular the Pan-Cancer-Nuceli-Seg-DICOM collection. This affects Google Cloud deployments set up according to the installation instructions provided by Slim viewer. When Slim viewer is backed by dcm4che, loading/rendering of annotations works, for the same study / dicom files.
This is imo critical.
Steps to reproduce
Case 1: IDC Portal -> fails
Result: Various error messages displayed and shown in browser console. No annotations rendered.
Case 2: Separate Google Cloud deployment -> fails
idc download 2.25.234091009181871968405618923996208732870
Result: Various error messages displayed and shown in browser console. No annotations rendered.
Case 3: Local installation of dcm4che -> works
Results: Clusters and when zooming in annotations are shown, as expected
The text was updated successfully, but these errors were encountered: