[전규진] 1차 과제 제출 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyj0
reviewed
Oct 9, 2024
Comment on lines
10
to
24
| @Override | ||
| public void updateQuality() { | ||
| if (item.sellIn == 0) { | ||
| item.quality = 0; | ||
| } else if (item.sellIn <= 5) { | ||
| item.quality += 3; | ||
| if (item.quality > 50) { | ||
| item.quality = 50; | ||
| } | ||
| } else if (item.sellIn <= 10) { | ||
| item.quality += 2; | ||
| if (item.quality > 50) { | ||
| item.quality = 50; | ||
| } | ||
| } |
There was a problem hiding this comment.
저도 비슷하게 코드를 짜보았는데, 네트워킹 시간에 파트장님이 말씀해주신대로 매직넘버를 관리하면 더 좋을 것 같네요!
0-x-14
approved these changes
Oct 11, 2024
| updatingItems[i] = new AgedBrieItem(items[i]); | ||
| } else if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { | ||
| updatingItems[i] = new BackStageItem(items[i]); | ||
| } else if (items[i].name.equals("Conjured Mana Cake")) { |
There was a problem hiding this comment.
테스트 코드 외에 다른 Conjured 아이템도 처리할 수 있도록 구현하면 유지보수 측면에서 더 좋을 것 같습니다!
| } | ||
| } else { | ||
| item.quality -= 4; | ||
| if (item.quality < 0) { |
There was a problem hiding this comment.
if (item.quality > 50)와 if (item.quality < 0)에 해당하는 부분들은 별도 메서드로 작성해주면 코드의 중복을 줄일 수 있을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit1