[노영재] 1차 과제 제출 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hades3
reviewed
Oct 6, 2024
Comment on lines
+18
to
+20
| public static ItemHandler getHandler(Item item) { | ||
| return handlerMap.getOrDefault(item.name, new RegularItemHandler()); | ||
| } |
There was a problem hiding this comment.
저는 일반적인 아이템에 대해서 처리하기 위해서 맵에 null 값을 넣는 방식을 사용했었는데, 영재님처럼 getOrDefault 메서드를 쓰는 것이 더 좋은 것 같습니다.
gikhoon
reviewed
Oct 7, 2024
|
|
||
| class GildedRose { | ||
| Item[] items; | ||
| public Item[] items; |
There was a problem hiding this comment.
Items 필드를 public으로 바꾼 이유가 궁금합니다! 외부에서 사용하지 않다고 판단되면 private으로 바꾸는 게 좋다고 생각합니다
| } | ||
| } | ||
| for (Item item : items) { | ||
| ItemHandler handler = ItemHandlerFactory.getHandler(item); |
There was a problem hiding this comment.
팩토리 메소드를 활용해 아이템에 해당하는 핸들러를 가지고 오는 방식 인상깊었습니다
| private static final Map<String, ItemHandler> handlerMap = new HashMap<>(); | ||
|
|
||
| static { | ||
| handlerMap.put("Aged Brie", new BrieItemHandler()); |
There was a problem hiding this comment.
핸들러 맵에 하드 코딩된 매직 넘버가 있으면 코드를 이해하기 어려울 것 같습니다. 상수화나 Item을 분류할 수 있는 Enum 값이 있으면 어떨까요?
gikhoon
reviewed
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.