[신예진] 1차 과제 제출 #12
Open
[신예진] 1차 과제 제출 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoungjaeRo
reviewed
Oct 10, 2024
| public class Conjured implements UpdateLogic{ | ||
|
|
||
| @Override | ||
| public void update(Item item) { |
There was a problem hiding this comment.
저의 품질 감소 로직보다 훨씬 더 가독성 좋고 간결하게 작성하신 거 같습니다!
잘 봤습니다.
YoungjaeRo
reviewed
Oct 10, 2024
Comment on lines
+3
to
+20
| import com.gildedrose.Item; | ||
|
|
||
| public class UpdateLogicFactory { | ||
| public static UpdateLogic getUpdateLogic(Item item){ | ||
| switch (item.name) { | ||
| case "Aged Brie": | ||
| return new AgedBrie(); | ||
| case "Backstage passes to a TAFKAL80ETC concert": | ||
| return new BackstagePass(); | ||
| case "Sulfuras, Hand of Ragnaros": | ||
| return new Sulfuras(); | ||
| case "Conjured Mana Cake": | ||
| return new Conjured(); | ||
| default: | ||
| return new DefaultItem(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
switch - case로 더 명확한 구조를 가지고 있네요!
다만 나중에 제품의 종류가 많아지면 코드가 더 길어질거 같습니다~!
qormoon
reviewed
Oct 10, 2024
Comment on lines
+16
to
+18
| for (Item item : items) { | ||
| UpdateLogic updateLogic = updateLogicFactory.getUpdateLogic(item); | ||
| updateLogic.update(item); |
There was a problem hiding this comment.
기존 for문을 향상된 for문으로 수정하여 가독성이 좋아진 것 같네요👍
Comment on lines
11
to
18
| item.quality++; | ||
| if (item.sellIn < 11 && item.quality < 50) { | ||
| item.quality++; | ||
| } | ||
| if (item.sellIn < 6 && item.quality < 50) { | ||
| item.quality++; | ||
| } | ||
| } |
There was a problem hiding this comment.
가독성을 위해 10 이하, 5 이하로 바꿔보는것도 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
신예진 과제 제출합니다.