Mag l1b CDF cleanup #1173
Merged
Mag l1b CDF cleanup #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxinelasp
requested review from
bourque,
sdhoyt and
subagonsouth
and removed request for
a team
tech3371
approved these changes
Nov 21, 2024
imap_processing/mag/l0/decom_mag.py
Outdated
| @@ -129,7 +129,7 @@ def generate_dataset( | |||
| direction.astype(str), | |||
| name="direction_label", | |||
| dims=["direction_label"], | |||
| attrs=attribute_manager.get_variable_attributes("direction_label"), | |||
| attrs=attribute_manager.get_variable_attributes("direction_label", check_schema=False), | |||
There was a problem hiding this comment.
cool. Glad that is an option in SAMMI!
Do you think this special case of metadata type for LABL_PTR_i attribute will be added to SAMMI in the near future? Because I think that's a standard from SPDF and we use it heavily and new mission may need to in the future.
There was a problem hiding this comment.
Yes, it's next up on my list to add, just have some other priorities to finish first! Long term I definitely want to fix up LABL_PTR_i.
Co-authored-by: Tenzin Choedon <[email protected]>
maxinelasp
merged commit 8d1ad62
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixing some ISTP and write_cdf bugs in MAG, shoring up the label variables, and generally making it so the code actually runs again.
Overview
Lots of fiddly CDF changes.