Add placeholder function for converting from esa_step to esa_energy_step #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subagonsouth
requested review from
a team,
bourque,
sdhoyt and
tech3371
and removed request for
a team
tech3371
reviewed
Nov 13, 2024
| @@ -341,3 +341,32 @@ def compute_hae_coordinates(dataset: xr.Dataset) -> dict[str, xr.DataArray]: | |||
| new_vars["hae_longitude"].values = pointing_coordinates[:, 1] | |||
|
|
|||
| return new_vars | |||
|
|
|||
|
|
|||
| def de_esa_energy_step(dataset: xr.Dataset) -> dict[str, xr.DataArray]: | |||
There was a problem hiding this comment.
Just clarification question. Is this function to figure out ESA voltages of input energy steps?
There was a problem hiding this comment.
Not quite. The esa_step in telemetry references an index in the sweep table that was used. The sweep table determines the voltages that the ESA inner and outer are set to and thus the energy bandpass of what particles get through. I don't quite understand all of the details of the algorithm that will be implemented in this function yet. But it will use the housekeeping data to look at voltages and then maybe map those voltages to an energy step. This ticket has some additional detail: #779
subagonsouth
merged commit 1e06973
into
IMAP-Science-Operations-Center:dev
17 checks passed
subagonsouth
deleted the
1145-hi-l1b-placeholder-function-for-esa_step-esa_energy_step
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Added a placeholder function for where the algorithm for computing
esa_energy_step. The function will eventually be updated to use the L1B housekeeping to correctly populate the data. See ticket #779Updated Files
esa_energy_step. For now, copy theesa_stepvalue.closes: #1145