Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to MAG L1B to scale based on compression flags #1117

Merged

Conversation

maxinelasp
Copy link
Contributor

Change Summary

This completes #1006 and finishes adding MAG compression to L1B.

Overview

L1B uses the compression_flags that I added in L1A to scale the output vectors. This adds another method and some new tests.

@maxinelasp maxinelasp added Ins: MAG Related to the MAG instrument Level: L1 Level 1 processing labels Nov 4, 2024
@maxinelasp maxinelasp added this to the Nov 2024 milestone Nov 4, 2024
@maxinelasp maxinelasp requested review from alastairtree and a team November 4, 2024 22:52
@maxinelasp maxinelasp self-assigned this Nov 4, 2024
@maxinelasp maxinelasp requested review from bourque, sdhoyt, subagonsouth and tech3371 and removed request for a team November 4, 2024 22:52
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc string. I understand on high level and it makes sense to me.

@maxinelasp maxinelasp merged commit 88a44f9 into IMAP-Science-Operations-Center:dev Nov 7, 2024
17 checks passed
@bourque bourque removed this from the Nov 2024 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: MAG Related to the MAG instrument Level: L1 Level 1 processing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants