Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update semver "2.0" to match new error handling from ILLIXR #225/227 #7

Open
e3m3 opened this issue Feb 25, 2021 · 0 comments
Open

Update semver "2.0" to match new error handling from ILLIXR #225/227 #7

e3m3 opened this issue Feb 25, 2021 · 0 comments
Assignees
@e3m3
Labels
enhancement New feature or request

Comments

@e3m3
Copy link

e3m3 commented Feb 25, 2021 •
edited
Loading

We are now using a new call for fatal errors, ILLIXR::abort(), defined in a new utility header called common/error_util.hpp. Existing calls to abort() are now ambiguous between the ILLIXR and std namespaces.

See PR #227.
@e3m3 e3m3 added the enhancement New feature or request label Feb 25, 2021
@e3m3 e3m3 self-assigned this Feb 25, 2021
e3m3 added a commit that referenced this issue Feb 25, 2021
@e3m3
Added call to ILLIXR::abort (#7)
c27a600
charmoniumQ pushed a commit that referenced this issue May 12, 2021
@e3m3
Integrated with new Switchboard API (#6)
4bf387d 
* Added call to ILLIXR::abort (#7)

* Testing integration with GTSAM v4.0.3 and switchboard

* Fixing integration with c++17

* Fixed mismatch alloc-deallocs reported as undefined behavior, and added updated .gitignore

* Updating switchboard integration to use fowarded constructor args allocation (#5)

* Added missing gtsam header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e3m3 e3m3

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@e3m3