Skip to content

Commit

Permalink
fix: prevent checkbox inline style from leaking (#308)
Browse files Browse the repository at this point in the history
Signed-off-by: Akshat Patel <[email protected]>
  • Loading branch information
Akshat55 authored May 29, 2024
1 parent bced86d commit d982860
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions sdk/react/src/lib/components/settings-context-pane.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export const SettingsContextPane = ({
}, [settings]);

Check warning on line 211 in sdk/react/src/lib/components/settings-context-pane.tsx

View workflow job for this annotation

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'setExternalSettings'. Either include it or remove the dependency array. If 'setExternalSettings' changes too often, find the parent component that defines it and wrap that definition in useCallback

return (
<div className={cx(styleContextPaneStyle, 'context-pane-content')}>
<div className='context-pane-content'>
{
selectedComponent &&
<SelectedComponentBreadcrumbs
Expand All @@ -237,7 +237,7 @@ export const SettingsContextPane = ({
</>
}
{
!selectedComponent && <>
!selectedComponent && <div className={cx(styleContextPaneStyle)}>
<Checkbox
id='setFragmentAsTemplate'
checked={fragment.labels && fragment.labels.includes('template')}
Expand Down Expand Up @@ -291,7 +291,7 @@ export const SettingsContextPane = ({
className={tooltipStyle}>
micro layout
</DefinitionTooltip>
</>
</div>
}
</div>
}
Expand Down

0 comments on commit d982860

Please sign in to comment.