Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version Numbers? #273

Open
ghost opened this issue Jul 27, 2023 · 1 comment
Open

Version Numbers? #273

ghost opened this issue Jul 27, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 27, 2023

https://github.com/IATI/refresher/blob/develop/src/constants/version.py

This number does not match https://github.com/IATI/refresher/releases
@ghost
Copy link
Author

ghost commented Jul 27, 2023

Note src/library/db.py funcs get_current_db_version and checkVersionMatch - so check carefully implications of changing!

ghost pushed a commit that referenced this issue Aug 29, 2023
@jarofgreen
Change where Solr deletion happens; change db migration detection; & …
90bd53c 
…misc

Only delete changed data from Solr just before adding in solrise stage!
https://iaticonnect.org/group/9/topic/proposed-update-iati-datastore

Database Migrations now run on migration var from src/constants/version.py only
#273
This removes need to make sure number var there moves in sync with migrations.
Also fixes bug in isUpgrade(fromVersion, toVersion) by scrapping function entirely.
Previously isUpgrade("1.1.1", "0.2.0") would return True
Not scrappincg number var yet, as that is stored in DB and may be used elsewhere.
That GitHub issue can remain open to look at that later.

Also remove combined_datasets_toclean var - it is only used once
and we don't need to copy what might be large data sets
ghost pushed a commit that referenced this issue Aug 29, 2023
@jarofgreen
Change where Solr deletion happens; change db migration detection; & …
f9d30c1 
…misc

Only delete changed data from Solr just before adding in solrise stage!
https://iaticonnect.org/group/9/topic/proposed-update-iati-datastore

Database Migrations now run on migration var from src/constants/version.py only
#273
This removes need to make sure number var there moves in sync with migrations.
Also fixes bug in isUpgrade(fromVersion, toVersion) by scrapping function entirely.
Previously isUpgrade("1.1.1", "0.2.0") would return True
Not scrappincg number var yet, as that is stored in DB and may be used elsewhere.
That GitHub issue can remain open to look at that later.

Also remove combined_datasets_toclean var - it is only used once
and we don't need to copy what might be large data sets
ghost pushed a commit that referenced this issue Aug 29, 2023
@jarofgreen
Change where Solr deletion happens; change db migration detection; & …
612ab62 
…misc

Only delete changed data from Solr just before adding in solrise stage!
https://iaticonnect.org/group/9/topic/proposed-update-iati-datastore

Database Migrations now run on migration var from src/constants/version.py only
#273
This removes need to make sure number var there moves in sync with migrations.
Also fixes bug in isUpgrade(fromVersion, toVersion) by scrapping function entirely.
Previously isUpgrade("1.1.1", "0.2.0") would return True
Not scrapping number var yet, as that is stored in DB and may be used elsewhere.
It is also used in a user agent string.
(That GitHub issue can remain open to look at that later.)

Also remove combined_datasets_toclean var - it is only used once
and we don't need to copy what might be large data sets
ghost pushed a commit that referenced this issue Aug 30, 2023
@jarofgreen
Change where Solr deletion happens; change db migration detection; & …
84c5b00 
…misc

Only delete changed data from Solr just before adding in solrise stage
https://iaticonnect.org/group/9/topic/proposed-update-iati-datastore
New DB column to track if data is in Solr or not

Database Migrations now run on migration var from src/constants/version.py only
#273
This removes need to make sure number var there moves in sync with migrations.
Also fixes bug in isUpgrade(fromVersion, toVersion) by scrapping function entirely.
Previously isUpgrade("1.1.1", "0.2.0") would return True
Not scrapping number var yet, as that is stored in DB and may be used elsewhere.
It is also used in a user agent string.
(That GitHub issue can remain open to look at that later.)

Also remove combined_datasets_toclean var - it is only used once
and we don't need to copy what might be large data sets
ghost pushed a commit that referenced this issue Aug 30, 2023
@jarofgreen
Change where Solr deletion happens; change db migration detection; & …
507f43f 
…misc

Only delete changed data from Solr just before adding in solrise stage
https://iaticonnect.org/group/9/topic/proposed-update-iati-datastore
New DB column to track if data is in Solr or not

Database Migrations now run on migration var from src/constants/version.py only
#273
This removes need to make sure number var there moves in sync with migrations.
Also fixes bug in isUpgrade(fromVersion, toVersion) by scrapping function entirely.
Previously isUpgrade("1.1.1", "0.2.0") would return True
Not scrapping number var yet, as that is stored in DB and may be used elsewhere.
It is also used in a user agent string.
(That GitHub issue can remain open to look at that later.)

Also remove combined_datasets_toclean var - it is only used once
and we don't need to copy what might be large data sets
@ghost ghost mentioned this issue Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants