Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH] Move to PNPM #1158

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

[TECH] Move to PNPM #1158

wants to merge 25 commits into from
+20,861 −14,554

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Nov 18, 2024 •
edited
Loading

Move to PNPM from Yarn.

Needed to fix some types here and there.
Was able to build and install an artifact just fine on my Linux PC, we should just double check on mac and windows as well.

HOW TO TEST

  • Check if dev mode works fine on all platforms
  • Check if the artifacts are also working fine (no need for full regression test, check only for errors on launch and basic features).

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added PR: WIP Type: Tech Non functional requirement or refactor labels Nov 18, 2024
@flavioislima
ci: install PNPM in workflow files
691f877
@flavioislima
ci: upgrade Node.js setup action to v4 across workflow files
92e56bd
@flavioislima
ci: remove pnpm cache configuration from workflow files
d1ae4a8
@flavioislima
chore: prettierignore and graceful-fs types
4f7a61c
@flavioislima
chore: update .gitignore and add .npmrc for node linker configuration
a28cc42
@flavioislima
chore: add sass dependency to package.json for parcel watcher
54bef48
@flavioislima
chore: update electron-builder to version 25.1.8 in package.json
74d12c2
@flavioislima
Revert "ci: install PNPM in workflow files"
48b507e 
This reverts commit 691f877.
@flavioislima
chore: add pnpm setup and node-gyp installation to workflow files
8944bef
@flavioislima
chore: add pnpm setup and install node-gyp for linux and mac
85b9812
@flavioislima
Revert "chore: update electron-builder to version 25.1.8 in package.j…
182062e 
…son"

This reverts commit 74d12c2.
@flavioislima
fix: types
f8dc494
@flavioislima
fix: pnpm and node-gyp on flatpak workflow
8c04623
@flavioislima
fix: update flatpak distribution command to use pnpm
b67de63
@flavioislima
fix: replace axios with fetch in Flatpak preparation script
a9fa1f7
@flavioislima
fix: add 'run' argument to spawnSync command in buildResetExtension.js
121fea7
@flavioislima flavioislima added PR: Ready-For-Review PR is ready to be reviewed by peers and removed PR: WIP labels Nov 19, 2024
@flavioislima flavioislima self-assigned this Nov 19, 2024
BrettCleary
BrettCleary approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. app runs fine in dev mode for me

@flavioislima flavioislima removed the PR: Ready-For-Review PR is ready to be reviewed by peers label Dec 3, 2024
@flavioislima flavioislima added PR: Ready-For-Test PR is ready to be tested by a QA Sustainability and removed Type: Tech Non functional requirement or refactor labels Dec 3, 2024
eliobricenov
eliobricenov approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@eliobricenov eliobricenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working for on macOS and Windows

nyghtstalker
nyghtstalker approved these changes Dec 6, 2024
View reviewed changes
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it in dev mode and on all platforms. The client launched and opened as expected with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyghtstalker nyghtstalker nyghtstalker approved these changes

@eliobricenov eliobricenov eliobricenov approved these changes

@BrettCleary BrettCleary BrettCleary approved these changes

@jiyuu-jin jiyuu-jin jiyuu-jin approved these changes

Assignees

@flavioislima flavioislima

Labels
PR: Ready-For-Test PR is ready to be tested by a QA Sustainability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flavioislima @jiyuu-jin @BrettCleary @eliobricenov @nyghtstalker