Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library status sort is not retained when returning from a game page #892

Open
nyghtstalker opened this issue May 16, 2024 · 2 comments · May be fixed by #1059
Open

Library status sort is not retained when returning from a game page #892

nyghtstalker opened this issue May 16, 2024 · 2 comments · May be fixed by #1059

Comments

@nyghtstalker
Copy link

Describe the bug

When a user applies a status sort in the library, clicks into a game, and then returns the sort is removed.

Add logs

N/A

Steps to reproduce

  1. Go to library
  2. Select the "Alphabetical A-Z" status sort option
  3. Click into any game
  4. Use the Back arrow to return to the library
  5. Observe that the status sort has been removed

Expected behavior

The status sort should be retained

Screenshots

image

image

hyperplay Version

Latest Stable

System Information

  • Windows 10
  • hyperplay Version 0.13.1

Additional information

No response
@nyghtstalker nyghtstalker added Type: Bug Severity: 3 - Low Minimal impact, typically cosmetic issues or minor bugs affecting a few users. labels May 16, 2024
@nyghtstalker
Copy link
Author

Confirmed this is still occurring.

@iamdavid0091 iamdavid0091 removed Type: Bug Severity: 3 - Low Minimal impact, typically cosmetic issues or minor bugs affecting a few users. labels Aug 16, 2024
@iratinho
Copy link

Hello! 👋
Is this issue free for grabs?

From my understanding, the library globally tracks its state using libraryState, and to address this issue, we should only assign a default filter when the cached state is undefined when mounting. This would ensure that the state is only updated based on actual user interactions or stored preferences.

I've identified the relevant code in question here:
https://github.com/HyperPlay-Gaming/hyperplay-desktop-client/blob/main/src/frontend/screens/Library/index.tsx#L96

I believe this should be the intended result:
https://github.com/user-attachments/assets/5ad40051-8b4b-4920-9eb8-127e02e87355

Could you please confirm if this approach aligns with the intended fix?
Thanks!

iratinho added a commit to iratinho/hyperplay-desktop-client that referenced this issue Sep 6, 2024
@iratinho
fix: Preserve library status sort (HyperPlay-Gaming#892)
e1a5683
@iratinho iratinho linked a pull request Sep 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Preserve library status sort iratinho/hyperplay-desktop-client
3 participants
@iamdavid0091 @iratinho @nyghtstalker