Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a new name to the c_conj in the inner-product function #3

Open
Schoyen opened this issue Oct 13, 2023 · 0 comments
Open

Give a new name to the c_conj in the inner-product function #3

Schoyen opened this issue Oct 13, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Schoyen
Copy link
Collaborator

Schoyen commented Oct 13, 2023

In the inner-product function we have implicitly assumed (via the naming of the arguments) that we are to compute the inner product of the same state vector c. However, this function is used for the inner product between any two state vectors a and b. Also, the user should still send in which of the two state vectors are complex conjugated. This allows for bivariational state vectors somewhere in the future.

@Schoyen Schoyen self-assigned this Oct 13, 2023
@Schoyen Schoyen added enhancement New feature or request good first issue Good for newcomers labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant