Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code returned is 0 even for failed para chain #126

Closed
hemz10 opened this issue Nov 29, 2023 · 2 comments · Fixed by #140
Closed

Exit code returned is 0 even for failed para chain #126

hemz10 opened this issue Nov 29, 2023 · 2 comments · Fixed by #140
Labels
bug Something isn't working Ready for review Ready for review

Comments

@hemz10
Copy link
Contributor

hemz10 commented Nov 29, 2023

Overview

Exit code should be 1 not 0 when the package fails to run the parachain.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Run the kurtosis package for known failing para chain.
  2. Exit code returned is 0 not 1

Expected Behavior

Exit code must be 1

Screenshots

Exit code is printed for debug purpose and can be found at the end of screenshot
image

@hemz10 hemz10 added the bug Something isn't working label Nov 29, 2023
@abhiyana
Copy link
Contributor

Can't reproduce, Parallel localnet is working fine

@abhiyana abhiyana added the Ready for review Ready for review label Nov 30, 2023
@hemz10
Copy link
Contributor Author

hemz10 commented Nov 30, 2023

Here Issue reported is not about parallel localnet working.
When any para chain fails, exit code returned is not one. Please check exit code for any para chain that fails.

@hemz10 hemz10 removed the Ready for review Ready for review label Nov 30, 2023
@abhiyana abhiyana linked a pull request Dec 1, 2023 that will close this issue
7 tasks
@abhiyana abhiyana added the Ready for review Ready for review label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for review Ready for review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants