Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more style fields/theme settings for menu #433

Open
jasonnrosa opened this issue Jul 25, 2022 · 0 comments
Open

Add more style fields/theme settings for menu #433

jasonnrosa opened this issue Jul 25, 2022 · 0 comments

Comments

@jasonnrosa
Copy link
Member

jasonnrosa commented Jul 25, 2022

From some feedback we got internally a lot of styles on the boilerplate's menu are hard coded/not available to be edited by a content creator (the menu uses rems which inherits font size from the body in theme settings right now so it kind of pulls in from theme settings but not in an intuitive way). I think it would make sense to be a little bit more prescriptive here (although we should still lean on the side of simple for boilerplate) so that we demonstrate best practices.

I think it could make sense to start with the menu font size + color options as a baseline to still keep things fairly simple but allow for a bit more flexibility in the theme editor the end user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant