Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Theme Settings to CSS Custom Properties #368

Open
2 tasks done
johnsfuller opened this issue Jul 29, 2021 · 0 comments
Open
2 tasks done

Map Theme Settings to CSS Custom Properties #368

johnsfuller opened this issue Jul 29, 2021 · 0 comments
Labels
blocked Issues that are blocked from being completed feature request

Comments

@johnsfuller
Copy link
Contributor

Since IE is being dropped, I suggest phasing out the theme-overrides.css stylesheet by:

  1. mapping all hubl field styles to css custom properties.
  2. replace current style hubl values with those custom properties
  3. move each section in theme-overrides.css (typography, buttons, form, etc) to its theme partial

See example:

:root {
  --color-body: {{ theme.typography.body_text.color }};
}
body {
  color: var(--color-body);
}

All styles in theme-overrides could be moved back to their relevant partial. This would allow for one main.css file – instead of a main and theme-overrides stylesheet.

Checklist

@jasonnrosa jasonnrosa added the blocked Issues that are blocked from being completed label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues that are blocked from being completed feature request
Projects
None yet
Development

No branches or pull requests

2 participants