From de4b7caf4a7801b3f8790a5f381f4bf83741688d Mon Sep 17 00:00:00 2001 From: Ivan Ilves Date: Tue, 30 Jan 2018 18:16:00 +0100 Subject: [PATCH] Re-use existing IAMRole structure --- core/controlplane/config/config.go | 1 + core/controlplane/config/config_test.go | 4 ++++ core/controlplane/config/templates/cloud-config-controller | 3 +++ core/controlplane/config/templates/cluster.yaml | 6 +++++- model/node_drainer.go | 5 +++-- 5 files changed, 16 insertions(+), 3 deletions(-) diff --git a/core/controlplane/config/config.go b/core/controlplane/config/config.go index 4f0ab07bd..9ca224053 100644 --- a/core/controlplane/config/config.go +++ b/core/controlplane/config/config.go @@ -104,6 +104,7 @@ func NewDefaultCluster() *Cluster { NodeDrainer: model.NodeDrainer{ Enabled: false, DrainTimeout: 5, + IAMRole: model.IAMRole{}, }, Oidc: model.Oidc{ Enabled: false, diff --git a/core/controlplane/config/config_test.go b/core/controlplane/config/config_test.go index d8aab5e19..d6c6b5f46 100644 --- a/core/controlplane/config/config_test.go +++ b/core/controlplane/config/config_test.go @@ -930,6 +930,7 @@ func TestNodeDrainerConfig(t *testing.T) { nodeDrainer: model.NodeDrainer{ Enabled: false, DrainTimeout: 5, + IAMRole: model.IAMRole{}, }, }, { @@ -937,10 +938,13 @@ func TestNodeDrainerConfig(t *testing.T) { experimental: nodeDrainer: enabled: true + iamRole: + arn: arn:aws:iam::0123456789012:role/asg-list-role `, nodeDrainer: model.NodeDrainer{ Enabled: true, DrainTimeout: 5, + IAMRole: model.IAMRole{ARN: model.ARN{Arn: "arn:aws:iam::0123456789012:role/asg-list-role"}}, }, }, { diff --git a/core/controlplane/config/templates/cloud-config-controller b/core/controlplane/config/templates/cloud-config-controller index a17264b2a..a61cb8861 100644 --- a/core/controlplane/config/templates/cloud-config-controller +++ b/core/controlplane/config/templates/cloud-config-controller @@ -1332,6 +1332,9 @@ write_files: k8s-app: kube-node-drainer-asg-status-updater annotations: scheduler.alpha.kubernetes.io/critical-pod: '' + {{if ne .Experimental.NodeDrainer.IAMRole.ARN.Arn "" -}} + iam.amazonaws.com/role: {{ .Experimental.NodeDrainer.IAMRole.ARN.Arn }} + {{ end }} spec: {{if .Experimental.Admission.Priority.Enabled -}} priorityClassName: system-node-critical diff --git a/core/controlplane/config/templates/cluster.yaml b/core/controlplane/config/templates/cluster.yaml index 2fe8986ac..73e23024a 100644 --- a/core/controlplane/config/templates/cluster.yaml +++ b/core/controlplane/config/templates/cluster.yaml @@ -1220,7 +1220,7 @@ addons: # When set to true this configures security groups for prometheus between nodes. # This includes the following ports: 10252, 10251, 10250, 9100, and 4194 - prometheus: + prometheus: securityGroupsEnabled: false # Experimental features will change in backward-incompatible ways @@ -1296,6 +1296,10 @@ experimental: enabled: false # Maximum time to wait, in minutes, for the node to be completely drained. Must be an integer between 1 and 60. drainTimeout: 5 + # IAM role to assume with kube2iam for the pod in "kube-node-drainer-asg-status-updater" deployment. + iamRole: + # Empty, inactive by default. Set it to valid ARN "arn: arn:aws:iam::0123456789012:role/roleName" to activate. + arn: "" # Configure OpenID Connect token authenticator plugin in Kubernetes API server. # For using Dex as a custom OIDC provider, please check "contrib/dex/README.md". diff --git a/model/node_drainer.go b/model/node_drainer.go index 6b2bec1a6..03ffa4962 100644 --- a/model/node_drainer.go +++ b/model/node_drainer.go @@ -6,8 +6,9 @@ import ( ) type NodeDrainer struct { - Enabled bool `yaml:"enabled"` - DrainTimeout int `yaml:"drainTimeout"` + Enabled bool `yaml:"enabled"` + DrainTimeout int `yaml:"drainTimeout"` + IAMRole IAMRole `yaml:"iamRole,omitempty"` } func (nd *NodeDrainer) DrainTimeoutInSeconds() int {