-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document, Test, Repair gempyor.parameters
Module
#276
Comments
Methods that need to be removed on the next PR for this issue:
See #277 (comment). |
This was originally a comment in GH-277 in relation to the second insufficient dates
If this is dead code then I think we should just remove it, but @saraloo and @jcblemai do y'all have any thoughts? See: #277 (comment). |
An open TODO for this issue that needs to be followed up on is adding descriptions to the examples of the new testing functions added per this comment: #277 (comment). Took care of the immediate one there, but will address others in a follow up. |
@TimothyWillard Are you systematically going through all |
@emprzy Yes, piece by piece. Some of the open ones can be found here: https://github.com/HopkinsIDD/flepiMoP/issues?q=is%3Aissue+is%3Aopen+document+test+. Although, I don't think that covers all of the outstanding work. |
Let me know if you want any extra hands on this, or if you have specific tasks you'd like to delegate to me! Always happy to (try to) help. |
Very similar to GH-246 but for the
gempyor.parameters
module. I'm starting here since this seems to be one of the simpler modules that interact with the configuration files directly. I also suspect that I'll find some bugs/unexpected behaviors along the way (such as the time series data frame being dropped issue I've already discovered) so I'll leave open the possibility of fixing that here. If the repairs get too large in size I'll migrate that to a separate issue.The text was updated successfully, but these errors were encountered: