Convert as_random_distribution
To Use scipy.stats
Distributions
#290
Labels
enhancement
Request for improvement or addition of new feature(s).
gempyor
Concerns the Python core.
medium priority
Medium priority.
Milestone
Is your feature request related to a problem? Please describe.
The
gempyor.utils.as_random_distribution/random_distribution_sampler
functions use a mix ofnp.random
rngs andscipy.stats
rngs. This makes testing these and functions that rely on these functions more convoluted then it should be as demonstrated bygempyor.testing. sample_fits_distribution
.See #277 (comment), #277 (comment).
Is your feature request related to a new application, scenario round, pathogen? Please describe.
The application is mostly for internal use in
gempyor
, it is unlikely that these functions will be used much externally but would assist in efforts to unit test and stabilizegempyor
.Describe the solution you'd like
Consolidate the logic in
gempyor.utils.as_random_distribution/random_distribution_sampler
andgempyor.testing. sample_fits_distribution
together and to use distributions fromscipy.stats
instead of fromnp.random
.The text was updated successfully, but these errors were encountered: