-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Python Exception Readability/Consistency #281
Comments
Creating a checklist of Python files within
|
Hello emprzy, |
Hi @Juhi-Lakdawala ! flepiMoP issues are typically for flepiMoP contributors only, sorry! |
…les. Adjusted formatting, punctuation, clarity, syntax, etc. in the errors/exceptions in `gempyor`'s initial_conditions.py, parameters.py, compartments.py, config_validator.py, inference.py. This will likely be one of three pulls to address HopkinsIDDGH-281.
We should strive to make exceptions readable and consistent throughout
gempyor
. Some general style guidelines include:ValueError
orException
,I'm certain there are more guidelines we could come up with though. In some rare cases we might also want to create custom exceptions, one such exceptions I could see an argument for already is
FlepimopConfigError
or similar for configuration related issues. However, we should evaluate if that's really needed before implementing.A good first step would be surveying
gempyor
for wherever weraise
something just to get an idea of where we're starting from. I expect that resolving this issue will take more than one PR and will probably be included as a part of other PRs along the way.Original context for this issue: https://github.com/HopkinsIDD/flepiMoP/pull/277/files#r1702272495.
The text was updated successfully, but these errors were encountered: