Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove path_prefix Argument From Parameters Class #275

Open
TimothyWillard opened this issue Jul 31, 2024 · 2 comments
Open

Remove path_prefix Argument From Parameters Class #275

TimothyWillard opened this issue Jul 31, 2024 · 2 comments
Labels
gempyor Concerns the Python core. low priority Low priority.
Milestone
Software Quality

Comments

@TimothyWillard
Copy link
Contributor

TimothyWillard commented Jul 31, 2024 •
edited
Loading

Converting a comment to an issue as I clean up the parameters.py file.

## TODO: ideally here path_prefix should not be used and all files loaded from modinf

This comment is by @jcblemai from 2024-04-19.
@TimothyWillard TimothyWillard added gempyor Concerns the Python core. low priority Low priority. labels Jul 31, 2024
TimothyWillard added a commit that referenced this issue Jul 31, 2024
@TimothyWillard
Preliminary documentation for gempyor.parameters
95e0437 
First draft of documentation for the `gempyor.parameters` module, most
importantly containing the `Parameters` class. Also added `__all__`
dunder to regulate exports and converted TODO comments to GitHub issues,
see GH-274, GH-275.
@emprzy
Copy link
Collaborator

emprzy commented Aug 15, 2024

@TimothyWillard have you worked on this at all?

@TimothyWillard
Copy link
Contributor Author

I have not. I just converted this from a TODO comment by @jcblemai into a GitHub issue while doing GH-277.

jcblemai pushed a commit that referenced this issue Oct 3, 2024
@TimothyWillard
Preliminary documentation for gempyor.parameters
4b1a854 
First draft of documentation for the `gempyor.parameters` module, most
importantly containing the `Parameters` class. Also added `__all__`
dunder to regulate exports and converted TODO comments to GitHub issues,
see GH-274, GH-275.
@TimothyWillard TimothyWillard added this to the Software Quality milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gempyor Concerns the Python core. low priority Low priority.
Projects
None yet
Milestone
Software Quality
Development

No branches or pull requests
2 participants
@TimothyWillard @emprzy