From a868b1f410bcd853bfc26e97c40a5ccdc6218c3a Mon Sep 17 00:00:00 2001
From: Dinopony <dinopony.gg@gmail.com>
Date: Thu, 12 Oct 2023 19:56:30 +0200
Subject: [PATCH] Added a generic Nintendo DS connector

---
 HintMachine/Games/INintendoDSConnector.cs | 40 ++++++++++++++++
 HintMachine/Games/MeteosConnector.cs      | 57 ++++++++++-------------
 HintMachine/HintMachine.csproj            |  1 +
 3 files changed, 66 insertions(+), 32 deletions(-)
 create mode 100644 HintMachine/Games/INintendoDSConnector.cs

diff --git a/HintMachine/Games/INintendoDSConnector.cs b/HintMachine/Games/INintendoDSConnector.cs
new file mode 100644
index 0000000..03d0dce
--- /dev/null
+++ b/HintMachine/Games/INintendoDSConnector.cs
@@ -0,0 +1,40 @@
+using System.Collections.Generic;
+using System.Linq;
+using static HintMachine.ProcessRamWatcher;
+
+namespace HintMachine.Games
+{
+    public abstract class INintendoDSConnector : IGameConnector
+    {
+        protected ProcessRamWatcher _ram = null;
+        protected long _dsRamBaseAddress = 0;
+
+        public INintendoDSConnector()
+        {}
+
+        public override bool Connect()
+        {
+            _ram = new ProcessRamWatcher("EmuHawk");
+            return _ram.TryConnect();
+        }
+
+        public override void Disconnect()
+        {
+            _ram = null;
+            _dsRamBaseAddress = 0;
+        }
+
+        protected bool FindRamSignature(byte[] ramSignature, uint signatureLookupAddr)
+        {
+            long ramBaseAddress = 0x36F01952020;
+            byte[] signatureBytes = _ram.ReadBytes(ramBaseAddress + signatureLookupAddr, ramSignature.Length);
+            if (Enumerable.SequenceEqual(signatureBytes, ramSignature))
+            {
+                _dsRamBaseAddress = ramBaseAddress;
+                return true;
+            }
+
+            return false;
+        }
+    }
+}
diff --git a/HintMachine/Games/MeteosConnector.cs b/HintMachine/Games/MeteosConnector.cs
index d59be51..fbbbd63 100644
--- a/HintMachine/Games/MeteosConnector.cs
+++ b/HintMachine/Games/MeteosConnector.cs
@@ -2,7 +2,7 @@
 
 namespace HintMachine.Games
 {
-    class MeteosConnector : IGameConnector
+    class MeteosConnector : INintendoDSConnector
     {
         private readonly HintQuestCumulative _sendBlocksQuest = new HintQuestCumulative
         {
@@ -30,15 +30,9 @@ class MeteosConnector : IGameConnector
 
         };
 
-        private ProcessRamWatcher _ram = null;
-        private long _nbPlayersAddr = 0;
-        private long _onePlayerGameAddr = 0;
-        private long _twoPlayersGameAddr = 0;
-        private long _threePlayersGameAddr = 0;
-        private long _fourPlayersGameAddr = 0;
-        private long _levelAddr = 0;
-        private bool starTripStarted = false;
-        private long maxLevel = 0;
+        private bool _starTripStarted = false;
+
+        // ---------------------------------------------------------
 
         public MeteosConnector()
         {
@@ -53,17 +47,14 @@ public MeteosConnector()
 
         public override bool Connect()
         {
-            _ram = new ProcessRamWatcher("EmuHawk");
-            if (!_ram.TryConnect())
+            if (!base.Connect()) 
                 return false;
 
-            _nbPlayersAddr = 0x36F019B50A0;
-            _onePlayerGameAddr = 0x36F01B538EC;
-            _twoPlayersGameAddr = 0x36F01B53A0C;
-            _threePlayersGameAddr = 0x36F01B53B2C;
-            _fourPlayersGameAddr = 0x36F01B53C4C;
-            _levelAddr = 0x36F01D11F1C;
-            return true;
+            byte[] METEOS_SIG = new byte[] { 0xFF, 0xDE, 0xFF, 0xE7, 0xFF, 0xDE, 0xFF, 0xE7, 0xFF, 0xDE, 0xFF, 0xE7, 0xFF, 0xDE, 0x47, 0x8B };
+            if (FindRamSignature(METEOS_SIG, 0))
+                return true;
+
+            return false;
         }
 
         public override void Disconnect()
@@ -73,9 +64,8 @@ public override void Disconnect()
 
         public override bool Poll()
         {
-            long _rightAddr = 0x0;
+            long level = _ram.ReadInt32(_dsRamBaseAddress + 0x3BFEFC);
 
-            long level = _ram.ReadInt32(_levelAddr);
             /* levelQuest might be added back later
             if (level < 16 && level > 0)
             {
@@ -97,39 +87,42 @@ public override bool Poll()
             //level = 16 is the ending
             if(level == 1)
             {
-                starTripStarted = true;
+                _starTripStarted = true;
                 _starTripQuest.UpdateValue(0);
             }
-            if (level == 16) {
-                if (starTripStarted) { 
+            if (level == 16)
+            {
+                if (_starTripStarted)
+                { 
                     _starTripQuest.UpdateValue(1);
-                    starTripStarted = false;
+                    _starTripStarted = false;
                 }
             }
             if(level > 16)
             {
-                starTripStarted = false;
-                int nbPlayers = _ram.ReadInt32(_nbPlayersAddr);
+                _starTripStarted = false;
+                int nbPlayers = _ram.ReadInt32(_dsRamBaseAddress + 0x63080);
 
+                long rightAddr = 0x0;
                 switch (nbPlayers)
                 {
                     case 1:
-                        _rightAddr = _onePlayerGameAddr;
+                        rightAddr = _dsRamBaseAddress + 0x2018CC;
                         break;
 
                     case 2:
-                        _rightAddr = _twoPlayersGameAddr;
+                        rightAddr = _dsRamBaseAddress + 0x2019EC;
                         break;
 
                     case 3:
-                        _rightAddr = _threePlayersGameAddr;
+                        rightAddr = _dsRamBaseAddress + 0x201B0C;
                         break;
 
                     case 4:
-                        _rightAddr = _fourPlayersGameAddr;
+                        rightAddr = _dsRamBaseAddress + 0x201C2C;
                         break;
                 }
-                _sendBlocksQuest.UpdateValue(_ram.ReadInt32(_rightAddr));
+                _sendBlocksQuest.UpdateValue(_ram.ReadInt32(rightAddr));
                 return true;
             }
             return true;
diff --git a/HintMachine/HintMachine.csproj b/HintMachine/HintMachine.csproj
index 6fb9f8d..9ca5133 100644
--- a/HintMachine/HintMachine.csproj
+++ b/HintMachine/HintMachine.csproj
@@ -129,6 +129,7 @@
       <SubType>Designer</SubType>
     </ApplicationDefinition>
     <Compile Include="ArchipelagoHintSession.cs" />
+    <Compile Include="Games\INintendoDSConnector.cs" />
     <Compile Include="Games\MeteosConnector.cs" />
     <Compile Include="Games\BustAMove4Connector.cs" />
     <Compile Include="Games\FZeroGXConnector.cs" />